Quantcast

dijitHidden class & breaking changes

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

dijitHidden class & breaking changes

adros
I would like to know, where should / could  the class 'dijitHidden' be used?

According to comment in its implementation it should be used on children of StackContainer (and descedants).

    /* To hide unselected panes in StackContainer etc. */

But it is used also on other elements in tutorials, e.g.:

    https://dojotoolkit.org/documentation/tutorials/1.10/dialogs_tooltips/index.html


I have been using this class everywhere in my application where I needed to hide an element
(because when it's suitable for tutorial, it's suitable for me...)
 
But recently, after updating the dojo from github, I have found out, that some of my pages are broken,
because there have been a breaking change in class implementation (using visibility: hidden, instead of display:none).

    https://bugs.dojotoolkit.org/ticket/18612
    https://github.com/dojo/dijit/commit/534157f1ce7473697bd3587d7b39248f50d0ac9e

And for example computing with dom-geometry, now does not work as expected, because dijitHidden elements now have height & width.


--
Dojo Toolkit: http://dojotoolkit.org/
Tutorials: http://dojotoolkit.org/documentation/

[hidden email]
To unsubscribe, visit: http://mail.dojotoolkit.org/mailman/listinfo/dojo-interest
Loading...