TimeTextBox Issues

classic Classic list List threaded Threaded
7 messages Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

TimeTextBox Issues

George Sexton

I'm getting a lot of negative feedback from my users over the dijit/form/TimeTextBox.

The major complaints are:

1) When the dropdown activates, the current value isn't displayed. This is a huge problem. Reference this 19 month old bug report:

https://bugs.dojotoolkit.org/ticket/18683

This is such a major usability hit, I don't understand why this is set as an enhancement request and not a high-priority defect. I looked at the source for this, and I don't see an obvious way to fix the problem. I also played with scrollOnFocus and it didn't have any impact.

2) dropDownDefaultValue seems to have no effect. I tried setting it to: "12:00 PM", "T12:00:00", "1970-01-01T12:00:00" and it didn't do anything. I looked through the source for this, and I can't understand how to make it work, and the docs are worse than useless.

3) This is my observation. A trailing space causes the time validation to fail. If I set "trim" to true, I wouldn't expect that. Actually, trimming trailing and leading white space should be done before applying the validation regardless of the value of trim.

Ideally, what I would like to achieve is:

1) If there's a value, I'd like it to be shown by default when the popup appears.

2) If there's not a value, I'd like a sensible default like mid-day to be shown, or visible in the select.

I'd appreciate any ideas on how to make the time text box work a little better.


--
George S.
MH Software, Inc.
Voice: 303 438 9585
http://www.connectdaily.com

--
Dojo Toolkit: http://dojotoolkit.org/
Tutorials: http://dojotoolkit.org/documentation/

[hidden email]
To unsubscribe, visit: http://mail.dojotoolkit.org/mailman/listinfo/dojo-interest
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: TimeTextBox Issues

dylanks
Hi George,

In general I prioritize issues highest within Trac if they either have
open pull requests, absolutely break behavior or look very easy to fix,
and then go from there. It's certainly likely that I misunderstood the
issue during a triage phase and labeled it as an enhancement rather than
defect.

Based on your feedback, it's clear that the TimeTextBox needs some
attention. Perhaps Bill Keese has some time to look into these issues,
though I know his work time for Dojo 1.x has been cut pretty
drastically. I've been focusing most of my time on Dojo 2, other than
reviewing and landing PRs and periodic releases.

You could work on pull requests and I'd be happy to review them and land
them once approved. Or you could wait until someone else in the
community needs this fixed and contributes a fix. Or an alternative
option to fund and expedite these fixes if you do not feel comfortable
contributing fixes would be to work with our team at SitePen through a
commercial JavaScript Support plan to get these fixed and landed in Dojo
asap. http://sitepen.com/support/

Those are the options I can think of, though perhaps there are other
alternatives I've not considered.

Regards,
-Dylan

on 3/14/17, 10:09 (GMT-07:00) George S. said the following:

> I'm getting a lot of negative feedback from my users over the
> dijit/form/TimeTextBox.
>
> The major complaints are:
>
> 1) When the dropdown activates, the current value isn't displayed. This
> is a huge problem. Reference this 19 month old bug report:
>
> https://bugs.dojotoolkit.org/ticket/18683
>
> This is such a major usability hit, I don't understand why this is set
> as an enhancement request and not a high-priority defect. I looked at
> the source for this, and I don't see an obvious way to fix the problem.
> I also played with scrollOnFocus and it didn't have any impact.
>
> 2) dropDownDefaultValue seems to have no effect. I tried setting it to:
> "12:00 PM", "T12:00:00", "1970-01-01T12:00:00" and it didn't do
> anything. I looked through the source for this, and I can't understand
> how to make it work, and the docs are worse than useless.
>
> 3) This is my observation. A trailing space causes the time validation
> to fail. If I set "trim" to true, I wouldn't expect that. Actually,
> trimming trailing and leading white space should be done before applying
> the validation regardless of the value of trim.
>
> Ideally, what I would like to achieve is:
>
> 1) If there's a value, I'd like it to be shown by default when the popup
> appears.
>
> 2) If there's not a value, I'd like a sensible default like mid-day to
> be shown, or visible in the select.
>
> I'd appreciate any ideas on how to make the time text box work a little
> better.
>
>
> --
> George S.
> *MH Software, Inc.*
> Voice: 303 438 9585
> http://www.connectdaily.com
>
--
Dojo Toolkit: http://dojotoolkit.org/
Tutorials: http://dojotoolkit.org/documentation/

[hidden email]
To unsubscribe, visit: http://mail.dojotoolkit.org/mailman/listinfo/dojo-interest
Co-Founder, Dojo Toolkit
CEO, SitePen, Inc.  http://www.sitepen.com/
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: TimeTextBox Issues

George Sexton

Dylan,


On 3/20/2017 12:42 AM, Dylan Schiemann wrote:
Hi George,

In general I prioritize issues highest within Trac if they either have
open pull requests, absolutely break behavior or look very easy to fix,
and then go from there. It's certainly likely that I misunderstood the
issue during a triage phase and labeled it as an enhancement rather than
defect.

Based on your feedback, it's clear that the TimeTextBox needs some
attention. Perhaps Bill Keese has some time to look into these issues,
though I know his work time for Dojo 1.x has been cut pretty
drastically. I've been focusing most of my time on Dojo 2, other than
reviewing and landing PRs and periodic releases.

You could work on pull requests and I'd be happy to review them and land
them once approved. Or you could wait until someone else in the

If you could give me a generalized outline of how to approach this, I'd take a look. I did look through the source code, but nothing just leaped out at me and said "Fix here".

The inheritance/mixins model makes for great functionality and inheritance, but it kind of obscure how things work.


community needs this fixed and contributes a fix. Or an alternative
option to fund and expedite these fixes if you do not feel comfortable
contributing fixes would be to work with our team at SitePen through a
commercial JavaScript Support plan to get these fixed and landed in Dojo
asap. http://sitepen.com/support/

Those are the options I can think of, though perhaps there are other
alternatives I've not considered.

Regards,
-Dylan

on 3/14/17, 10:09 (GMT-07:00) George S. said the following:
I'm getting a lot of negative feedback from my users over the
dijit/form/TimeTextBox.

The major complaints are:

1) When the dropdown activates, the current value isn't displayed. This
is a huge problem. Reference this 19 month old bug report:

https://bugs.dojotoolkit.org/ticket/18683

This is such a major usability hit, I don't understand why this is set
as an enhancement request and not a high-priority defect. I looked at
the source for this, and I don't see an obvious way to fix the problem.
I also played with scrollOnFocus and it didn't have any impact.

2) dropDownDefaultValue seems to have no effect. I tried setting it to:
"12:00 PM", "T12:00:00", "1970-01-01T12:00:00" and it didn't do
anything. I looked through the source for this, and I can't understand
how to make it work, and the docs are worse than useless.

3) This is my observation. A trailing space causes the time validation
to fail. If I set "trim" to true, I wouldn't expect that. Actually,
trimming trailing and leading white space should be done before applying
the validation regardless of the value of trim.

Ideally, what I would like to achieve is:

1) If there's a value, I'd like it to be shown by default when the popup
appears.

2) If there's not a value, I'd like a sensible default like mid-day to
be shown, or visible in the select.

I'd appreciate any ideas on how to make the time text box work a little
better.


-- 
George S.
*MH Software, Inc.*
Voice: 303 438 9585
http://www.connectdaily.com


--
George S.
MH Software, Inc.
Voice: 303 438 9585
http://www.connectdaily.com

--
Dojo Toolkit: http://dojotoolkit.org/
Tutorials: http://dojotoolkit.org/documentation/

[hidden email]
To unsubscribe, visit: http://mail.dojotoolkit.org/mailman/listinfo/dojo-interest
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: TimeTextBox Issues

Ron M

We have actually already solved problem #1 with the following change. We created our own TimeTextBox widget that inherits from the dijit one, and added the following function:

 

                openDropDown: function(/*Function*/callback) {

                                // summary: scroll the time drop down to selected time

                                this.inherited(arguments);

 

                                var selectedNode = query(".dijitTimePickerItemSelected", this.dropDown.domNode);

                                if (selectedNode[0]) {

                                                selectedNode[0].scrollIntoView();

                                }

                }

 

I'm not sure if that is the best solution, but seems to work for us. We have not looked into the other issues.

 

Ron

 

 

From: [hidden email] [mailto:[hidden email]] On Behalf Of George S.
Sent: Monday, March 20, 2017 12:17 PM
To: [hidden email]
Subject: Re: [Dojo-interest] TimeTextBox Issues

 

Dylan,

 

On 3/20/2017 12:42 AM, Dylan Schiemann wrote:

Hi George,
 
In general I prioritize issues highest within Trac if they either have
open pull requests, absolutely break behavior or look very easy to fix,
and then go from there. It's certainly likely that I misunderstood the
issue during a triage phase and labeled it as an enhancement rather than
defect.
 
Based on your feedback, it's clear that the TimeTextBox needs some
attention. Perhaps Bill Keese has some time to look into these issues,
though I know his work time for Dojo 1.x has been cut pretty
drastically. I've been focusing most of my time on Dojo 2, other than
reviewing and landing PRs and periodic releases.
 
You could work on pull requests and I'd be happy to review them and land
them once approved. Or you could wait until someone else in the


If you could give me a generalized outline of how to approach this, I'd take a look. I did look through the source code, but nothing just leaped out at me and said "Fix here".

The inheritance/mixins model makes for great functionality and inheritance, but it kind of obscure how things work.



 
community needs this fixed and contributes a fix. Or an alternative
option to fund and expedite these fixes if you do not feel comfortable
contributing fixes would be to work with our team at SitePen through a
commercial JavaScript Support plan to get these fixed and landed in Dojo
asap. http://sitepen.com/support/
 
Those are the options I can think of, though perhaps there are other
alternatives I've not considered.
 
Regards,
-Dylan
 
on 3/14/17, 10:09 (GMT-07:00) George S. said the following:
I'm getting a lot of negative feedback from my users over the
dijit/form/TimeTextBox.
 
The major complaints are:
 
1) When the dropdown activates, the current value isn't displayed. This
is a huge problem. Reference this 19 month old bug report:
 
https://bugs.dojotoolkit.org/ticket/18683
 
This is such a major usability hit, I don't understand why this is set
as an enhancement request and not a high-priority defect. I looked at
the source for this, and I don't see an obvious way to fix the problem.
I also played with scrollOnFocus and it didn't have any impact.
 
2) dropDownDefaultValue seems to have no effect. I tried setting it to:
"12:00 PM", "T12:00:00", "1970-01-01T12:00:00" and it didn't do
anything. I looked through the source for this, and I can't understand
how to make it work, and the docs are worse than useless.
 
3) This is my observation. A trailing space causes the time validation
to fail. If I set "trim" to true, I wouldn't expect that. Actually,
trimming trailing and leading white space should be done before applying
the validation regardless of the value of trim.
 
Ideally, what I would like to achieve is:
 
1) If there's a value, I'd like it to be shown by default when the popup
appears.
 
2) If there's not a value, I'd like a sensible default like mid-day to
be shown, or visible in the select.
 
I'd appreciate any ideas on how to make the time text box work a little
better.
 
 
-- 
George S.
*MH Software, Inc.*
Voice: 303 438 9585
http://www.connectdaily.com
 

 

--
George S.
MH Software, Inc.
Voice: 303 438 9585
http://www.connectdaily.com


--
Dojo Toolkit: http://dojotoolkit.org/
Tutorials: http://dojotoolkit.org/documentation/

[hidden email]
To unsubscribe, visit: http://mail.dojotoolkit.org/mailman/listinfo/dojo-interest
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: TimeTextBox Issues

George Sexton

Ronald,

Thanks very much for sharing this. I'll play with it some and make a pull request. Problem #2 should be pretty easy, I just need to find the median node and scroll it into view.


On 3/20/2017 5:28 PM, Ronald MacCracken wrote:

We have actually already solved problem #1 with the following change. We created our own TimeTextBox widget that inherits from the dijit one, and added the following function:

 

                openDropDown: function(/*Function*/callback) {

                                // summary: scroll the time drop down to selected time

                                this.inherited(arguments);

 

                                var selectedNode = query(".dijitTimePickerItemSelected", this.dropDown.domNode);

                                if (selectedNode[0]) {

                                                selectedNode[0].scrollIntoView();

                                }

                }

 

I'm not sure if that is the best solution, but seems to work for us. We have not looked into the other issues.

 

Ron

 

 

From: [hidden email] [[hidden email]] On Behalf Of George S.
Sent: Monday, March 20, 2017 12:17 PM
To: [hidden email]
Subject: Re: [Dojo-interest] TimeTextBox Issues

 

Dylan,

 

On 3/20/2017 12:42 AM, Dylan Schiemann wrote:

Hi George,
 
In general I prioritize issues highest within Trac if they either have
open pull requests, absolutely break behavior or look very easy to fix,
and then go from there. It's certainly likely that I misunderstood the
issue during a triage phase and labeled it as an enhancement rather than
defect.
 
Based on your feedback, it's clear that the TimeTextBox needs some
attention. Perhaps Bill Keese has some time to look into these issues,
though I know his work time for Dojo 1.x has been cut pretty
drastically. I've been focusing most of my time on Dojo 2, other than
reviewing and landing PRs and periodic releases.
 
You could work on pull requests and I'd be happy to review them and land
them once approved. Or you could wait until someone else in the


If you could give me a generalized outline of how to approach this, I'd take a look. I did look through the source code, but nothing just leaped out at me and said "Fix here".

The inheritance/mixins model makes for great functionality and inheritance, but it kind of obscure how things work.



 
community needs this fixed and contributes a fix. Or an alternative
option to fund and expedite these fixes if you do not feel comfortable
contributing fixes would be to work with our team at SitePen through a
commercial JavaScript Support plan to get these fixed and landed in Dojo
asap. http://sitepen.com/support/
 
Those are the options I can think of, though perhaps there are other
alternatives I've not considered.
 
Regards,
-Dylan
 
on 3/14/17, 10:09 (GMT-07:00) George S. said the following:
I'm getting a lot of negative feedback from my users over the
dijit/form/TimeTextBox.
 
The major complaints are:
 
1) When the dropdown activates, the current value isn't displayed. This
is a huge problem. Reference this 19 month old bug report:
 
https://bugs.dojotoolkit.org/ticket/18683
 
This is such a major usability hit, I don't understand why this is set
as an enhancement request and not a high-priority defect. I looked at
the source for this, and I don't see an obvious way to fix the problem.
I also played with scrollOnFocus and it didn't have any impact.
 
2) dropDownDefaultValue seems to have no effect. I tried setting it to:
"12:00 PM", "T12:00:00", "1970-01-01T12:00:00" and it didn't do
anything. I looked through the source for this, and I can't understand
how to make it work, and the docs are worse than useless.
 
3) This is my observation. A trailing space causes the time validation
to fail. If I set "trim" to true, I wouldn't expect that. Actually,
trimming trailing and leading white space should be done before applying
the validation regardless of the value of trim.
 
Ideally, what I would like to achieve is:
 
1) If there's a value, I'd like it to be shown by default when the popup
appears.
 
2) If there's not a value, I'd like a sensible default like mid-day to
be shown, or visible in the select.
 
I'd appreciate any ideas on how to make the time text box work a little
better.
 
 
-- 
George S.
*MH Software, Inc.*
Voice: 303 438 9585
http://www.connectdaily.com
 

 

--
George S.
MH Software, Inc.
Voice: 303 438 9585
http://www.connectdaily.com




--
George S.
MH Software, Inc.
Voice: 303 438 9585
http://www.connectdaily.com

--
Dojo Toolkit: http://dojotoolkit.org/
Tutorials: http://dojotoolkit.org/documentation/

[hidden email]
To unsubscribe, visit: http://mail.dojotoolkit.org/mailman/listinfo/dojo-interest
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: TimeTextBox Issues

George Sexton
In reply to this post by dylanks



On 3/20/2017 12:42 AM, Dylan Schiemann wrote:
Hi George,

In general I prioritize issues highest within Trac if they either have
open pull requests, absolutely break behavior or look very easy to fix,
and then go from there. It's certainly likely that I misunderstood the
issue during a triage phase and labeled it as an enhancement rather than
defect.

Based on your feedback, it's clear that the TimeTextBox needs some
attention. Perhaps Bill Keese has some time to look into these issues,
though I know his work time for Dojo 1.x has been cut pretty
drastically. I've been focusing most of my time on Dojo 2, other than
reviewing and landing PRs and periodic releases.

You could work on pull requests and I'd be happy to review them and l
I've submitted a pull request. The JSF-Clabot stuff seems to be designed to not issue useful error messages.

Can you help me understand how to make it work?


and
them once approved. Or you could wait until someone else in the
community needs this fixed and contributes a fix. Or an alternative
option to fund and expedite these fixes if you do not feel comfortable
contributing fixes would be to work with our team at SitePen through a
commercial JavaScript Support plan to get these fixed and landed in Dojo
asap. http://sitepen.com/support/

Those are the options I can think of, though perhaps there are other
alternatives I've not considered.

Regards,
-Dylan

on 3/14/17, 10:09 (GMT-07:00) George S. said the following:
I'm getting a lot of negative feedback from my users over the
dijit/form/TimeTextBox.

The major complaints are:

1) When the dropdown activates, the current value isn't displayed. This
is a huge problem. Reference this 19 month old bug report:

https://bugs.dojotoolkit.org/ticket/18683

This is such a major usability hit, I don't understand why this is set
as an enhancement request and not a high-priority defect. I looked at
the source for this, and I don't see an obvious way to fix the problem.
I also played with scrollOnFocus and it didn't have any impact.

2) dropDownDefaultValue seems to have no effect. I tried setting it to:
"12:00 PM", "T12:00:00", "1970-01-01T12:00:00" and it didn't do
anything. I looked through the source for this, and I can't understand
how to make it work, and the docs are worse than useless.

3) This is my observation. A trailing space causes the time validation
to fail. If I set "trim" to true, I wouldn't expect that. Actually,
trimming trailing and leading white space should be done before applying
the validation regardless of the value of trim.

Ideally, what I would like to achieve is:

1) If there's a value, I'd like it to be shown by default when the popup
appears.

2) If there's not a value, I'd like a sensible default like mid-day to
be shown, or visible in the select.

I'd appreciate any ideas on how to make the time text box work a little
better.


-- 
George S.
*MH Software, Inc.*
Voice: 303 438 9585
http://www.connectdaily.com


--
George S.
MH Software, Inc.
Voice: 303 438 9585
http://www.connectdaily.com

--
Dojo Toolkit: http://dojotoolkit.org/
Tutorials: http://dojotoolkit.org/documentation/

[hidden email]
To unsubscribe, visit: http://mail.dojotoolkit.org/mailman/listinfo/dojo-interest
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: TimeTextBox Issues

George Sexton

Never mind. It's no wonder people can't contribute. I should be required to spend two hours to figure out how to do a pull request, make the fix, and then be stumped because git supplied the wrong email address, screwing up JSF-clabot which is so poorly written that it can't event explain the real problem.


On 3/22/2017 4:30 PM, George S. wrote:



On 3/20/2017 12:42 AM, Dylan Schiemann wrote:
Hi George,

In general I prioritize issues highest within Trac if they either have
open pull requests, absolutely break behavior or look very easy to fix,
and then go from there. It's certainly likely that I misunderstood the
issue during a triage phase and labeled it as an enhancement rather than
defect.

Based on your feedback, it's clear that the TimeTextBox needs some
attention. Perhaps Bill Keese has some time to look into these issues,
though I know his work time for Dojo 1.x has been cut pretty
drastically. I've been focusing most of my time on Dojo 2, other than
reviewing and landing PRs and periodic releases.

You could work on pull requests and I'd be happy to review them and l
I've submitted a pull request. The JSF-Clabot stuff seems to be designed to not issue useful error messages.

Can you help me understand how to make it work?


and
them once approved. Or you could wait until someone else in the
community needs this fixed and contributes a fix. Or an alternative
option to fund and expedite these fixes if you do not feel comfortable
contributing fixes would be to work with our team at SitePen through a
commercial JavaScript Support plan to get these fixed and landed in Dojo
asap. http://sitepen.com/support/

Those are the options I can think of, though perhaps there are other
alternatives I've not considered.

Regards,
-Dylan

on 3/14/17, 10:09 (GMT-07:00) George S. said the following:
I'm getting a lot of negative feedback from my users over the
dijit/form/TimeTextBox.

The major complaints are:

1) When the dropdown activates, the current value isn't displayed. This
is a huge problem. Reference this 19 month old bug report:

https://bugs.dojotoolkit.org/ticket/18683

This is such a major usability hit, I don't understand why this is set
as an enhancement request and not a high-priority defect. I looked at
the source for this, and I don't see an obvious way to fix the problem.
I also played with scrollOnFocus and it didn't have any impact.

2) dropDownDefaultValue seems to have no effect. I tried setting it to:
"12:00 PM", "T12:00:00", "1970-01-01T12:00:00" and it didn't do
anything. I looked through the source for this, and I can't understand
how to make it work, and the docs are worse than useless.

3) This is my observation. A trailing space causes the time validation
to fail. If I set "trim" to true, I wouldn't expect that. Actually,
trimming trailing and leading white space should be done before applying
the validation regardless of the value of trim.

Ideally, what I would like to achieve is:

1) If there's a value, I'd like it to be shown by default when the popup
appears.

2) If there's not a value, I'd like a sensible default like mid-day to
be shown, or visible in the select.

I'd appreciate any ideas on how to make the time text box work a little
better.


-- 
George S.
*MH Software, Inc.*
Voice: 303 438 9585
http://www.connectdaily.com


--
George S.
MH Software, Inc.
Voice: 303 438 9585
http://www.connectdaily.com



--
George S.
MH Software, Inc.
Voice: 303 438 9585
http://www.connectdaily.com

--
Dojo Toolkit: http://dojotoolkit.org/
Tutorials: http://dojotoolkit.org/documentation/

[hidden email]
To unsubscribe, visit: http://mail.dojotoolkit.org/mailman/listinfo/dojo-interest
Loading...